New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From<Digest> no longer panics #5832

Merged
merged 2 commits into from Jun 4, 2018

Conversation

Projects
None yet
4 participants
@illicitonion
Copy link
Contributor

illicitonion commented May 17, 2018

We often do this conversion on things returned from a remote execution
API, and we shouldn't panic based on uncontrolled external input.

@illicitonion illicitonion requested review from ity and dotordogh May 17, 2018

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/frompanics branch from e92ad23 to e3e8821 May 17, 2018

From<Digest> no longer panics
We often do this conversion on things returned from a remote execution
API, and we shouldn't panic based on uncontrolled external input.

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/frompanics branch from e3e8821 to aa4cc8a Jun 4, 2018

@illicitonion illicitonion merged commit 009208f into pantsbuild:master Jun 4, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/frompanics branch Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment