New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script BinaryUtils can be captured as snapshots #5835

Merged
merged 3 commits into from May 18, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented May 17, 2018

This is a hacky transition step until we pull the BinaryUtils subsystem
into v2.

I could not work out how to unit test this change, as I could not create
a context object which actually had the options I specified.

An integration test, however, will follow shortly.

@@ -190,6 +191,17 @@ class Script(BinaryToolBase):
"""
platform_dependent = False

def hackily_snapshot(self, context):
bootstrapdir = self.__class__.global_instance().get_options().pants_bootstrapdir

This comment has been minimized.

@stuhood

stuhood May 17, 2018

Member

A constructed instance should have options as well... so self.get_options() should work...?

illicitonion added some commits May 16, 2018

Script BinaryUtils can be captured as snapshots
This is a hacky transition step until we pull the BinaryUtils subsystem
into v2.

I could not work out how to unit test this change, as I could not create
a context object which actually had the options I specified.

An integration test, however, will follow shortly.

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/scriptbinutils branch from 3ca4a89 to 1611a87 May 18, 2018

@illicitonion illicitonion merged commit 3836e42 into pantsbuild:master May 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment