New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommandRunners implement a single trait #5836

Merged
merged 1 commit into from May 17, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented May 17, 2018

No description provided.

@illicitonion illicitonion requested review from stuhood , ity and dotordogh May 17, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks!


impl super::CommandRunner for CommandRunner {
///
/// Runs a command on this machine in the passed working directory.
///
/// This takes ownership of a TempDir rather than a Path to ensure that the TempDir can't be

This comment has been minimized.

@stuhood

stuhood May 17, 2018

Member

Stale. Would be good to preserve, but not a big deal.

@stuhood stuhood merged commit bd97ef7 into pantsbuild:master May 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/commandrunnertrait branch May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment