New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra workunit from coursier resolve #5837

Merged
merged 1 commit into from May 18, 2018

Conversation

Projects
None yet
4 participants
@baroquebobcat
Copy link
Contributor

baroquebobcat commented May 17, 2018

Problem

See #5395. There's an extra workunit in coursier resolve. Coursier resolve has an extra workunit between running the task and invoking the Coursier binary.

Solution

This removes that workunit and changes the passed labels so that the output on the commandline and in the server is as expected

Result

Fixes #5395

Remove extra workunit from coursier resolve
fixes #5395. Coursier resolve has an extra workunit between running the task and invoking the Coursier binary. This removes that workunit and changes the passed labels so that the output on the commandline and in the server is as expected

@baroquebobcat baroquebobcat requested review from benjyw and wisechengyi May 17, 2018

@baroquebobcat

This comment has been minimized.

Copy link
Contributor

baroquebobcat commented May 17, 2018

With this patch, there's just two coursier work units. One for the task and one for invoking the binary:
screen shot 2018-05-17 at 4 50 30 pm
screen shot 2018-05-17 at 4 51 16 pm

@wisechengyi
Copy link
Contributor

wisechengyi left a comment

Thanks Nora!

@benjyw

benjyw approved these changes May 18, 2018

@baroquebobcat baroquebobcat merged commit a3174db into pantsbuild:master May 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment