New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloc uses v2 process execution #5840

Merged
merged 4 commits into from May 18, 2018

Conversation

Projects
None yet
4 participants
@illicitonion
Copy link
Contributor

illicitonion commented May 18, 2018

No description provided.

@illicitonion illicitonion requested review from stuhood , ity and dotordogh May 18, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

input_pathglobs = PathGlobs(tuple(input_files), ())
input_snapshot = self.context._scheduler.product_request(Snapshot, [input_pathglobs])[0]

directory_digest = self.context._scheduler.merge_directories((

This comment has been minimized.

@stuhood

stuhood May 18, 2018

Member

Could refer to #5502 here and mention moving more of this into @rules.

@ity

ity approved these changes May 18, 2018

Copy link
Member

ity left a comment

looks great!

@stuhood stuhood merged commit 88fdfdd into pantsbuild:master May 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment