New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all rust dependencies #5845

Merged
merged 1 commit into from May 19, 2018

Conversation

Projects
None yet
5 participants
@stuhood
Copy link
Member

stuhood commented May 19, 2018

Updated all rust dependencies (ie, ran cargo update).

@stuhood stuhood requested review from baroquebobcat , jsirois and illicitonion May 19, 2018

@kwlzn

kwlzn approved these changes May 19, 2018

@stuhood stuhood merged commit bbbd37a into pantsbuild:master May 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/update-rust-deps branch May 19, 2018

@benjyw

This comment has been minimized.

Copy link
Contributor

benjyw commented May 20, 2018

This broke stuff for me:

info: using existing install for '1.25.0-x86_64-apple-darwin'
info: override toolchain for '/Users/benjyw/src/pants' set to '1.25.0-x86_64-apple-darwin'

  1.25.0-x86_64-apple-darwin unchanged - rustc 1.25.0 (84203cac6 2018-03-25)

info: component 'rustfmt-preview' for target 'x86_64-apple-darwin' is up to date
info: component 'rust-src' is up to date
[Waiting for /Users/benjyw/.cache/pants/rust/cargo/bin/cargo fetch --manifest-path /Users/benjyw/src/pants/src/rust/engine/Cargo.toml (pid 13228) to complete]
generating /var/folders/4t/btjfp2sn7pldd1h5_fn6mwxc0000gn/T/tmpPeHlqO/native_engine.c
Not overwriting /Users/benjyw/src/pants/src/rust/engine/src/cffi/native_engine.c because it is unchanged
Not overwriting /Users/benjyw/src/pants/src/rust/engine/src/cffi/native_engine.cflags because it is unchanged
   Compiling grpcio-sys v0.2.3
error: failed to run custom build command for `grpcio-sys v0.2.3`
process didn't exit successfully: `/Users/benjyw/src/pants/src/rust/engine/target/release/build/grpcio-sys-e6b0f84b0857bd92/build-script-build` (exit code: 101)
--- stdout
cargo:rerun-if-changed=grpc_wrap.c
cargo:rerun-if-changed=grpc
cargo:rerun-if-env-changed=GRPCIO_SYS_USE_PKG_CONFIG
running: "cmake" "/Users/benjyw/.cache/pants/rust/cargo/registry/src/github.com-1ecc6299db9ec823/grpcio-sys-0.2.3/grpc" "-DCMAKE_INSTALL_PREFIX=/Users/benjyw/src/pants/src/rust/engine/target/release/build/grpcio-sys-99d5bdd7b5a68e68/out" "-DCMAKE_C_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_C_COMPILER=/usr/bin/cc" "-DCMAKE_CXX_FLAGS= -stdlib=libc++ -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_CXX_COMPILER=/usr/bin/c++" "-DCMAKE_BUILD_TYPE=Release"
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/benjyw/src/pants/src/rust/engine/target/release/build/grpcio-sys-99d5bdd7b5a68e68/out/build
running: "cmake" "--build" "." "--target" "grpc" "--config" "Release" "--"
[  0%] Generating err_data.c
[  0%] Built target lhash
[  0%] Built target stack
[  0%] Built target pkcs8_lib
[  2%] Built target bytestring
[  2%] Built target buf
[  2%] Built target base64
[  2%] Built target pool
[  2%] Built target sha
[  2%] Built target md4
Scanning dependencies of target md5
Scanning dependencies of target aes
[  2%] Built target modes
[  4%] Building C object third_party/boringssl/crypto/md5/CMakeFiles/md5.dir/md5.c.o
[  4%] Building C object third_party/boringssl/crypto/aes/CMakeFiles/aes.dir/aes.c.o
[  4%] Building C object third_party/boringssl/crypto/aes/CMakeFiles/aes.dir/key_wrap.c.o
[  4%] Building C object third_party/boringssl/crypto/aes/CMakeFiles/aes.dir/mode_wrappers.c.o
[  4%] Built target aes
[  4%] Built target md5

--- stderr
CMake Warning at CMakeLists.txt:122 (message):
  gRPC_INSTALL will be forced to FALSE because gRPC_ZLIB_PROVIDER is "module"


CMake Warning at CMakeLists.txt:184 (message):
  gRPC_PROTOBUF_PROVIDER is "module" but PROTOBUF_ROOT_DIR is wrong


CMake Warning at CMakeLists.txt:251 (message):
  gRPC_GFLAGS_PROVIDER is "module" but GFLAGS_ROOT_DIR is wrong


CMake Warning at CMakeLists.txt:271 (message):
  gRPC_BENCHMARK_PROVIDER is "module" but BENCHMARK_ROOT_DIR is wrong


CMake Warning (dev):
  Policy CMP0042 is not set: MACOSX_RPATH is enabled by default.  Run "cmake
  --help-policy CMP0042" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  MACOSX_RPATH is not specified for the following targets:

   grpc_csharp_ext
   zlib

This warning is for project developers.  Use -Wno-dev to suppress it.

# runtime/internal/sys
flag provided but not defined: -goversion
usage: compile [options] file.go...
  -%	debug non-static initializers
  -+	compiling runtime
  -A	for bootstrapping, allow 'any' type
  -B	disable bounds checking
  -D path
    	set relative path for local imports
  -E	debug symbol export
  -I directory
    	add directory to import search path
  -K	debug missing line numbers
  -M	debug move generation
  -N	disable optimizations
  -P	debug peephole optimizer
  -R	debug register optimizer
  -S	print assembly listing
  -V	print compiler version
  -W	debug parse tree after type checking
  -asmhdr file
    	write assembly header to file
  -buildid id
    	record id as the build id in the export metadata
  -complete
    	compiling complete package (no C or assembly)
  -cpuprofile file
    	write cpu profile to file
  -d list
    	print debug information about items in list
  -dynlink
    	support references to Go symbols defined in other shared libraries
  -e	no limit on number of errors reported
  -f	debug stack frames
  -g	debug code generation
  -h	halt on error
  -i	debug line number stack
  -importmap definition
    	add definition of the form source=actual to import map
  -installsuffix suffix
    	set pkg directory suffix
  -j	debug runtime-initialized variables
  -l	disable inlining
  -largemodel
    	generate code that assumes a large memory model
  -linkobj file
    	write linker-specific object to file
  -live
    	debug liveness analysis
  -m	print optimization decisions
  -memprofile file
    	write memory profile to file
  -memprofilerate rate
    	set runtime.MemProfileRate to rate
  -msan
    	build code compatible with C/C++ memory sanitizer
  -newexport
    	use new export format (default true)
  -nolocalimports
    	reject local (relative) imports
  -o file
    	write output to file
  -p path
    	set expected package import path
  -pack
    	write package file instead of object file
  -r	debug generated wrappers
  -race
    	enable race detector
  -s	warn about composite literals that can be simplified
  -shared
    	generate code that can be linked into a shared library
  -ssa
    	use SSA backend to generate code (default true)
  -trimpath prefix
    	remove prefix from recorded source file paths
  -u	reject unsafe code
  -v	increase debug verbosity
  -w	debug type checking
  -wb
    	enable write barrier (default true)
  -x	debug lexer
make[3]: *** [third_party/boringssl/crypto/err/err_data.c] Error 2
make[3]: *** Deleting file `third_party/boringssl/crypto/err/err_data.c'
make[2]: *** [third_party/boringssl/crypto/err/CMakeFiles/err.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/grpc.dir/rule] Error 2
make: *** [grpc] Error 2
thread 'main' panicked at '
command did not execute successfully, got: exit code: 2

build script failed, must exit now', /Users/benjyw/.cache/pants/rust/cargo/registry/src/github.com-1ecc6299db9ec823/cmake-0.1.31/src/lib.rs:643:5
note: Run with `RUST_BACKTRACE=1` for a backtrace.


Failed to build native engine.
@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented May 20, 2018

@benjyw : Ew. Sorry.

Presumably clearing under ~/.cache/pants/rust resolves it?

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented May 20, 2018

That also looks more likely to have been related to #5842... did you bisect to this commit?

@stuhood stuhood referenced this pull request May 20, 2018

Closed

Update to rust 1.26 #5803

@benjyw

This comment has been minimized.

Copy link
Contributor

benjyw commented May 21, 2018

I did. It works immediately before this change (which includes #5842), but not after this change. So I'm pretty sure it's this change...

@benjyw

This comment has been minimized.

Copy link
Contributor

benjyw commented May 21, 2018

And rm -rf ~/.cache/pants/rust did not fix :(

@benjyw

This comment has been minimized.

Copy link
Contributor

benjyw commented May 21, 2018

Pants in now unusable for me at HEAD. Ideas?

@benjyw

This comment has been minimized.

Copy link
Contributor

benjyw commented May 21, 2018

This happens not infrequently, and is a real pain. How do we get to rust stability?

@benjyw

This comment has been minimized.

Copy link
Contributor

benjyw commented May 21, 2018

Also note that pulling across these changes leaves all sorts of non-gitignored cruft in src/rust/engine/process_execution/bazel_protos/src.

@illicitonion

This comment has been minimized.

Copy link
Contributor

illicitonion commented May 21, 2018

Pants in now unusable for me at HEAD. Ideas?

I can't reproduce, but I suspect this will end up being #5742 's fault somehow...

Also note that pulling across these changes leaves all sorts of non-gitignored cruft in src/rust/engine/process_execution/bazel_protos/src.

This is probably a result of #5742

This happens not infrequently, and is a real pain. How do we get to rust stability?

#5742 should make this a lot more stable in the future, but it's possible there are some weird issues pulling back and forth across it...

@benjyw

This comment has been minimized.

Copy link
Contributor

benjyw commented May 21, 2018

I don't think so - this happens at bbbd37a, before #5742.

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented May 21, 2018

@benjyw : It looks like maybe this is a $GOROOT leakage: astaxie/beego#2859 (comment)

@benjyw

This comment has been minimized.

Copy link
Contributor

benjyw commented May 21, 2018

Yeah, I saw that thread. My system golang was 1.9. I both upgraded to 1.10 and downgraded to 1.8, neither helped. Also, I don't have $GOROOT set anyway.

@benjyw

This comment has been minimized.

Copy link
Contributor

benjyw commented May 21, 2018

For posterity, this is fixed by:

rm -rf ~/.cache/pants/bin/go
rm -rf ~/.cache/pants/rust

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment