New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core has a CommandRunner #5850

Merged
merged 1 commit into from May 21, 2018

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

illicitonion commented May 21, 2018

Instead of making a new one for each ExecuteProcess Node.

This will allow us to configure a local vs remote execution strategy,
and use a single local or remote CommandRunner which we set up when we
make our Core.

Core has a CommandRunner
Instead of making a new one for each ExecuteProcess Node.

This will allow us to configure a local vs remote execution strategy,
and use a single local or remote CommandRunner which we set up when we
make our Core.

@illicitonion illicitonion requested review from stuhood , ity and dotordogh May 21, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

@kwlzn

kwlzn approved these changes May 21, 2018

@illicitonion illicitonion merged commit 0aaf538 into pantsbuild:master May 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:dwagnerhall/corecommandrunner branch May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment