New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use write_all not write #5852

Merged
merged 1 commit into from May 21, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented May 21, 2018

write may not write all bytes, and will not return an error if only a
partial write was performed.

This was surfaced by clippy; I don't think clippy is stable enough to
turn on on CI, but I may start running occasional clippy checks to look
for issues / things to clean up.

Use write_all not write
write may not write all bytes, and will not return an error if only a
partial write was performed.

This was surfaced by clippy; I don't think clippy is stable enough to
turn on on CI, but I may start running occasional clippy checks to look
for issues / things to clean up.

@illicitonion illicitonion requested review from stuhood , ity and dotordogh May 21, 2018

@stuhood
Copy link
Member

stuhood left a comment

Yikes. Thank you clippy.

@illicitonion illicitonion merged commit c5d00b7 into pantsbuild:master May 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/clippy branch May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment