New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust compilation is more robust and fast #5857

Merged
merged 1 commit into from May 22, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented May 22, 2018

  1. Make sure we're in the repo before compiling, so that .cargo/config
    is picked up. Otherwise running pants from outside the repo root
    fails to link on OSX.
  2. Only build the engine, not all binaries, when what we want is the
    engine.
Rust compilation is more robust and fast
1. Make sure we're in the repo before compiling, so that .cargo/config
   is picked up. Otherwise running pants from outside the repo root
   fails to link on OSX.
2. Only build the engine, not all binaries, when what we want is the
   engine.

@illicitonion illicitonion requested a review from jsirois May 22, 2018

@illicitonion illicitonion merged commit 813d810 into pantsbuild:master May 22, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@stuhood stuhood deleted the twitter:dwagnerhall/ruststuff branch May 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment