New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark things which generate cffi for change detection #5883

Merged
merged 2 commits into from May 30, 2018

Conversation

Projects
None yet
4 participants
@illicitonion
Copy link
Contributor

illicitonion commented May 30, 2018

Right now, modifications to native.py don't trigger re-generation of the
native_engine.c file, which leads to a stale engine being used.

Mark things which generate cffi for change detection
Right now, modifications to native.py don't trigger re-generation of the
native_engine.c file, which leads to a stale engine being used.

@illicitonion illicitonion requested review from stuhood and jsirois May 30, 2018

@kwlzn

kwlzn approved these changes May 30, 2018

Copy link
Member

kwlzn left a comment

lgtm

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented May 30, 2018

Unrelated failure in Travis. Merging.

@stuhood stuhood merged commit 10f9848 into pantsbuild:master May 30, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment