New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visualize-to option post addition of Sessions #5885

Merged
merged 4 commits into from May 31, 2018

Conversation

Projects
None yet
2 participants
@stuhood
Copy link
Member

stuhood commented May 30, 2018

Problem

When Sessions were added, the "static" reference to the most recent ExecutionRequest was removed from the Scheduler. But that reference was still in use by _maybe_visualize (used in the background when --native-engine-visualize-to was set)... which didn't have an integration test.

Solution

Since visualizing "the most recent request" didn't really make sense in all contexts where _maybe_visualize was used anyway, switch to visualizing all roots that have been requested within a Session. Cover this with an integration test.

Result

--native-engine-visualize-to works, and is protected against future breakage.

@stuhood stuhood requested review from jsirois , illicitonion and kwlzn May 30, 2018

@kwlzn

kwlzn approved these changes May 30, 2018

Copy link
Member

kwlzn left a comment

LGTM

@stuhood stuhood merged commit 62d8b26 into pantsbuild:master May 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/fix-visualize-to-post-sessions branch May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment