New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustify go_protobuf_library #5887

Merged
merged 1 commit into from Jun 1, 2018

Conversation

Projects
None yet
2 participants
@traviscrawford
Copy link
Member

traviscrawford commented May 31, 2018

Now that go_protobuf_library has been added, I found a couple minor issues in real-world use-cases. Not all protobuf IDL files contain a Go namespace, so we should fall back to the package. Also, we should use the Go namespace as-is in the path names as sometimes there are path elements that contain a . (e.g.: github.com) which is a Go thing.

Travis Crawford
Robustify go_protobuf_library
Now that `go_protobuf_library` has been added, I found a couple minor issues in real-world use-cases. Not all protobuf IDL files contain a go namespace, so we should fall back to the package. Also, we should use the go namespace as-is in the path names as sometimes there are path elements that contain a `.` (e.g.: `github.com`) which is a Go thing.
@stuhood

stuhood approved these changes Jun 1, 2018

@stuhood stuhood merged commit e8c8076 into pantsbuild:master Jun 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@traviscrawford traviscrawford deleted the traviscrawford:travis/tweak_go_protobuf branch Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment