Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
source attribute is automatically promoted to sources #5908
This means that either the
This is a step towards all
For backwards compatibility, both attributes will be populated on
A hook is provided for rules to perform validation on
This is a breaking change for rules which use both the
This is also a breaking change for rules which use the
This is also a slightly breaking change for the
This is also a breaking change in that in means that the source
2 times, most recently
Jun 4, 2018
@stuhood This is now ready for review. Each commit is standalone reviewable.
(I want to add general tests for sources hydration which cover these cases: 8c8e6f0 but can't quite work out what the execution request I'm trying to craft is... Ideally this would be a unit test, not an integration test.) I'm specifically trying to write a test which exercises both the extracting and the hydrating of a
There are two unit test APIs for "creating targets" on
The relationship between these two methods is quite similar to the relationship between what happens when we parse a target from a BUILD file vs what happens when we inject a target during codegen (respectively).
So, I think there are two options:
More generally, the long term goal is to remove
left a comment
Thanks Daniel... this looks good.
I think you've begun to touch on #4535 a bit, so I'd love some thought given to the direction we want to head in for
@stuhood With subclassing of fields, would you be expecting a
All of that needs design. Perhaps we could whiteboard it next week if you're interested?