New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Root/Inner Entry cases in RuleGraph #5914

merged 1 commit into from Jun 5, 2018


None yet
2 participants
Copy link

stuhood commented Jun 5, 2018

Added an enum EntryWithDeps to unify the two types of Entry that were capable of having dependencies. Used that enum to simplify many matches, merge the two Entry dependency maps on RuleGraph, and simplify methods that no longer needed to be generic.

@stuhood stuhood requested a review from baroquebobcat Jun 5, 2018

Copy link

baroquebobcat left a comment

Looks good to me. I like how it moves some of the previous imperative knowledge into declarative types.


This comment has been minimized.

Copy link

stuhood commented Jun 5, 2018

5 fewer panics!

@stuhood stuhood merged commit 5733f2a into pantsbuild:master Jun 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@stuhood stuhood deleted the twitter:stuhood/merge-root-and-inner branch Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment