Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Put the ChangeCalculator implementation next to TargetRootsCalculator #5917
While working on #5912, I found the code related to target calculation (currently just used along the
After discussing it with @stuhood, we came to the conclusion that bringing the code together and simplifying the dependencies would make this part of the codebase easier to work with. And thus this PR aims to do just that.
The user should not be aware of this change. It is internal codebase refactoring.
PS. I skipped the pre-commit hook due to a bug with my isort.sh script, so it may fail on CI before I fix the import order.
left a comment
Looks good to me, although we need to get
To unblock the PR, invoking the downloaded
@alanbato : Yea, some fixes are needed: https://travis-ci.org/pantsbuild/pants/jobs/389339946#L927
Let's keep iterating on getting