New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rust log level comparison #5918

Merged
merged 1 commit into from Jun 7, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented Jun 6, 2018

I've manually verified that this works by adding some warn!, info! and
debug! statements, and seeing that they get displayed appropriately.

There isn't a non-convoluted test I can add here, because we don't info
or warn log things on any usefully testable paths.

Fix rust log level comparison
I've manually verified that this works by adding some warn!, info! and
debug! statements, and seeing that they get displayed appropriately.

There isn't a non-convoluted test I can add here, because we don't info
or warn log things on any usefully testable paths.

@illicitonion illicitonion requested review from stuhood and cosmicexplorer Jun 6, 2018

@stuhood

stuhood approved these changes Jun 6, 2018

Copy link
Member

stuhood left a comment

Not sure what apocalyptic thing happened to the networking in Travis boxes, but I've re-kicked-off the shards.

@stuhood stuhood merged commit 8c2e484 into pantsbuild:master Jun 7, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@stuhood stuhood deleted the twitter:dwagnerhall/rustlogging branch Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment