New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `SelectInterpreter` read of `interpreter.path` #5925

Merged
merged 1 commit into from Jun 7, 2018

Conversation

Projects
None yet
3 participants
@jsirois
Copy link
Member

jsirois commented Jun 7, 2018

Since SelectInterpreter does not use results dirs, we change the
interpreter.path file whose format has changed to be
interpreter.info.

Fix `SelectInterpreter` read of `interpreter.path`
Since `SelectInterpreter` does not use results dirs, we change the
`interpreter.path` file whose format has changed to be
`interpreter.info`.

@jsirois jsirois requested a review from illicitonion Jun 7, 2018

@jsirois jsirois referenced this pull request Jun 7, 2018

Merged

Upgrade to pex 1.4.3. #5910

@illicitonion
Copy link
Contributor

illicitonion left a comment

Rubberstamp :)

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Jun 7, 2018

Getting CI green is tough today. Many shard re-starts due to networking issues on Travis CI. I'll be back online in ~2 hours (12:30pm Mountain Time) to check in on this, but if someone wants to merge ahead of that, feel free.

@kwlzn

kwlzn approved these changes Jun 7, 2018

@jsirois jsirois merged commit 67a2b59 into pantsbuild:master Jun 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/5906-follow-up-fix branch Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment