Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Re-shade zinc to avoid classpath collisions with annotation processors. #5953
Zinc used to be shaded before the
Shade zinc, and ensure that our annotation processor uses a very old guava in order to attempt to force collisions in future.
On Tue, Jun 12, 2018, 11:38 AM Stu Hood ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/python/pants/backend/jvm/subsystems/zinc.py <#5953 (comment)>: > @@ -49,13 +49,17 @@ def register_options(cls, register): Shader.exclude_package('scala', recursive=True), Shader.exclude_package('xsbt', recursive=True), Shader.exclude_package('xsbti', recursive=True), + # Unfortunately, is loaded reflectively by the compiler. + Shader.exclude_package('org.apache.logging.log4j', recursive=True), @wisechengyi <https://github.com/wisechengyi> : This only affects annotation processors, of which we have relatively few. I've tested it with them. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5953 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAkZhgg06zAQMYF1hqFmaP89tfwEa5IXks5t8AqMgaJpZM4Uk1Vs> .