Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Misc rust fixes #5982
So, thinking about this more, the timing of this change is unfortunate. Landing this will basically guarantee that no rust code is cherry-pickable between master and
Cherry-picking this would probably be very low risk (...it really is crazy how good the compiler is), but if this branch is relatively easy to recreate, it would be awesome to wait a week before landing it. If not, I guess landing it and gambling on whether we need to cherry pick it would be ok. I'm probably fine either way: up to you.