New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Pants as a pex. #6014

Merged
merged 1 commit into from Jun 25, 2018

Conversation

Projects
None yet
5 participants
@jsirois
Copy link
Member

jsirois commented Jun 24, 2018

This adds release automation of a Pants pex to our Travis CI job when
run against a release_* tag. There is more to be done to consume the pex
in the setup script we point users to, but the actual release should now
be covered.

Fixes #4896

Release Pants as a pex.
This adds release automation of a Pants pex to our Travis CI job when
run against a release_* tag. There is more to be done to consume the pex
in the setup script we point users to, but the actual release should now
be covered.

Fixes #4896

@jsirois jsirois requested review from kwlzn , illicitonion and stuhood Jun 25, 2018

@jsirois jsirois merged commit c5a46e9 into pantsbuild:master Jun 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:issues/4896 branch Jun 25, 2018

@kwlzn
Copy link
Member

kwlzn left a comment

nice!

@stuhood
Copy link
Member

stuhood left a comment

Thanks for doing this!

file: dist/deploy/pex/*
skip_cleanup: true
on:
# We only release a pex for Pants releases, which are tagged.

This comment has been minimized.

@stuhood

stuhood Jun 25, 2018

Member

So, while only building pexes for tags should reduce storage costs, Twitter does currently rely on the fact that travis publishes wheels for "all origin branch shas", in that we consume nightly/master wheels for a nightly smoketest.

I think that the storage costs for pexes should be relatively small, and that most of the cost would be from people actually fetching them. @benjyw : does that sound right?

If so, it would be good to ship pexes for all branches (but not PRs).

This comment has been minimized.

@jsirois

jsirois Jun 25, 2018

Member

2 things:

  1. This deploys using github releases which only work for tags. I think this is a good thing for our public releases - pypi and github releases are standard discoverable things, an s3 bucket isn't as much.
  2. #6016 will require storing pexes for all shas temporarily in S3. This will need a new bucket with a TTL attached to auto-purge. Wheels can get moved there too.

I'd like to defer the per-branch bit until work on point 2.

This comment has been minimized.

@stuhood

stuhood Jun 25, 2018

Member

Ok, works for me. Thanks.

As long as the -p flag continues to work, Twitter can wait to migrate to the new mechanism.

This comment has been minimized.

@benjyw

benjyw Jun 28, 2018

Contributor

It is true that our costs are 99% bandwidth, not storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment