New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .vscode/ folder to .gitignore #6020

Merged
merged 2 commits into from Jun 25, 2018

Conversation

Projects
None yet
4 participants
@alanbato
Copy link
Member

alanbato commented Jun 25, 2018

Problem

Workspace-specific configuration on Visual Studio Code creates a .vscode/ folder to store the settings.json to store said configuration. Since there were already some editor-specific ignores in gitignore, I figured I might as well include VSCode's.

Solution

I added .vscode/ to the .gitignore file.

Result

Now VSCode users won't see a dirty workspace when using project-defined configs :)

@stuhood
Copy link
Member

stuhood left a comment

We're not doing a great job of this in general, but:

To anchor something to the root of the repository, you should prefix it with /. Would you mind doing that for this one (assuming the .vscode directory will only be created at the root).

We'll do a separate cleanup pass for the other ones.

Anchor the .vscode folder to root
Changing `.vscode/` to `/.vscode/`
@alanbato

This comment has been minimized.

Copy link
Member

alanbato commented Jun 25, 2018

Done 👍

@wisechengyi

This comment has been minimized.

Copy link
Contributor

wisechengyi commented Jun 25, 2018

@alanbato independently, it might be a good idea to document how to work on Pants with vscode if you get a chance :)

@kwlzn

kwlzn approved these changes Jun 25, 2018

@kwlzn kwlzn merged commit 12711f2 into pantsbuild:master Jun 25, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment