New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rust 1.27 #6035

Merged
merged 4 commits into from Jun 27, 2018

Conversation

Projects
None yet
4 participants
@stuhood
Copy link
Member

stuhood commented Jun 27, 2018

Let's try this again, but with more resolve!

Bump to rust 1.27, explicitly use Itertools::flatten, re-apply rustfmt, and bump the travis OSX image.

@stuhood stuhood requested review from jsirois , illicitonion , kwlzn and dotordogh Jun 27, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Jun 27, 2018

Individual commits should be useful for review.

IMO, although unfortunate, not being stuck on an older version of rust is worth dropping support for OSX < 10.11.

@stuhood stuhood referenced this pull request Jun 27, 2018

Closed

Update to rust 1.26 #5803

@kwlzn

kwlzn approved these changes Jun 27, 2018

Copy link
Member

kwlzn left a comment

lgtm

@illicitonion
Copy link
Contributor

illicitonion left a comment

The rust linux shard had a flaky failure; I re-ran it and it went green.

Thanks for pushing this!

@stuhood stuhood referenced this pull request Jun 27, 2018

Merged

Misc rust fixes #5982

@stuhood stuhood merged commit 9be434e into pantsbuild:master Jun 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stuhood stuhood deleted the twitter:stuhood/rust-1.27 branch Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment