New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go-import meta tag ends with /> #6036 #6037

Merged
merged 2 commits into from Jun 28, 2018

Conversation

Projects
None yet
2 participants
@shuoli84
Copy link
Contributor

shuoli84 commented Jun 27, 2018

Problem

Fix #6036

Solution

Modify regex.

Result

Now some repo with can be discovered

@jsirois
Copy link
Member

jsirois left a comment

Thanks for filing the issue and supplying a fix! The change looks good, but it would be great to back it up by adding a test to https://github.com/pantsbuild/pants/blob/master/contrib/go/tests/python/pants_test/contrib/go/subsystems/test_go_import_meta_tag_reader.py.

lishuo
@jsirois
Copy link
Member

jsirois left a comment

Thanks @shuoli84!

@jsirois jsirois merged commit feb5a91 into pantsbuild:master Jun 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment