New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up process execution python API #6051

Merged
merged 2 commits into from Jun 29, 2018

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

illicitonion commented Jun 29, 2018

  • Descriptions are important, so no longer optional.
  • Env should be empty where possible, so default it thus.
  • Set WorkUnit outcome
Clean up process execution python API
* Descriptions are important, so no longer optional.
* Env should be empty where possible, so default it thus.
* Set WorkUnit outcome

@illicitonion illicitonion requested a review from dotordogh Jun 29, 2018

@illicitonion illicitonion merged commit d483288 into pantsbuild:master Jun 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/epr/cleanup branch Jun 29, 2018

@stuhood
Copy link
Member

stuhood left a comment

Much cleaner. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment