New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log more in rust tests #6060

Merged
merged 2 commits into from Jul 3, 2018

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

illicitonion commented Jul 2, 2018

This should expose recursive backtraces when we see:
'thread panicked while panicking'

Log more in rust tests
This should expose recursive backtraces when we see:
'thread panicked while panicking'

@illicitonion illicitonion requested a review from jsirois Jul 2, 2018

@jsirois

jsirois approved these changes Jul 2, 2018

@kwlzn

kwlzn approved these changes Jul 2, 2018

@@ -223,7 +223,7 @@ if [[ "${skip_rust_tests:-false}" == "false" ]]; then
test_threads_flag="--test-threads=1"
fi

RUST_BACKTRACE=1 "${REPO_ROOT}/build-support/bin/native/cargo" test --all \
RUST_BACKTRACE=all "${REPO_ROOT}/build-support/bin/native/cargo" test --all --nocapture \

This comment has been minimized.

@jsirois

jsirois Jul 2, 2018

Member

Looks like this needs to be cargo test --all -- --nocapture.

@kwlzn

kwlzn approved these changes Jul 3, 2018

@kwlzn kwlzn merged commit cafd732 into pantsbuild:master Jul 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/rusttests branch Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment