New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run `futurize --stage1` to make safe changes for python 3 compatibility. #6063

Merged
merged 1 commit into from Jul 3, 2018

Conversation

Projects
None yet
4 participants
@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Jul 2, 2018

Problem

First stage of Python 3 port

Solution

Stage 1 of the futurize tool only makes safe changes, and it keeps the code base at Python 2. See http://python-future.org/futurize.html#forwards-conversion-stage1. Stage 2 will later convert this to actual Python 3 code.

This command was ran on

  • src/python
  • test/python
  • contrib
  • examples
  • pants-plugins
  • build-support/bin/check-header-helper.py

(not ran on testprojects)

Run `futurize --stage1` to make safe changes for python 3 compatibility.
Stage 1 of the futurize tool only makes safe changes, and it keeps the code base at Python 2. See http://python-future.org/futurize.html#forwards-conversion-stage1. Stage 2 will later convert this to actual Python 3 code.

This command was ran on
- src/python
- test/python
- contrib
- examples
- pants-plugins
- build-support/bin/check-header-helper.py

(not ran on testprojects)
@Eric-Arellano

This comment has been minimized.

Copy link
Contributor

Eric-Arellano commented Jul 2, 2018

@stuhood stuhood requested review from kwlzn , CMLivingston and mateor Jul 2, 2018

@stuhood

stuhood approved these changes Jul 2, 2018

Copy link
Member

stuhood left a comment

Thanks!

@@ -8,6 +8,8 @@
#
# usage: check_header_helper.py dir1 [ dir2 [ ... ] ]

This comment has been minimized.

@stuhood

stuhood Jul 2, 2018

Member

Oh the irony of the "header check" script not using its own headers!

@kwlzn

kwlzn approved these changes Jul 3, 2018

@stuhood stuhood merged commit 5a4d7e9 into pantsbuild:master Jul 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:futurize branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment