New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port backend/native #6084

Merged
merged 2 commits into from Jul 10, 2018

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Jul 9, 2018

Part of porting project #6062

@@ -103,7 +104,7 @@ def _hello_world_source_environment(self, file_name, contents, scheduler_request
with safe_open(source_file_path, mode='wb') as fp:
fp.write(contents)

products, subjects = zip(*scheduler_request_specs)
products, subjects = list(zip(*scheduler_request_specs))

This comment has been minimized.

@Eric-Arellano

Eric-Arellano Jul 9, 2018

Contributor

@cosmicexplorer I'm not sure what this line is being used for - IntelliJ warns products, subjects is never used. Is it safe to remove this line?

@stuhood

stuhood approved these changes Jul 9, 2018

Copy link
Member

stuhood left a comment

Should be able to kill the dead line you identified.

@stuhood stuhood merged commit 789ed2c into pantsbuild:master Jul 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Jul 10, 2018

Thanks a lot!

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:port-native branch Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment