New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port fs #6091

Merged
merged 1 commit into from Jul 11, 2018

Conversation

Projects
None yet
3 participants
@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Jul 10, 2018

Part of #6062

P.S. Let me know if these PRs are too small - I've been keeping it one directory per PR so that we can use git bisect / debug easier and make it easier to do code review. This means we'll eventually have 54 PRs in total (spreadsheet tracking this all)

@stuhood stuhood merged commit 6aabc10 into pantsbuild:master Jul 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cosmicexplorer

This comment has been minimized.

Copy link
Contributor

cosmicexplorer commented Jul 12, 2018

Google docs is telling me I need permission to view that spreadsheet -- unsure if the access is intentionally limited. imho one directory per PR is fantastic for the exact reasons you described, having a consistent metric makes it easier to not accidentally cut corners even if the diffs are tiny (imho). If there are reasons to make them larger, go ahead, but this is fine (imho).

@Eric-Arellano

This comment has been minimized.

Copy link
Contributor

Eric-Arellano commented Jul 12, 2018

@cosmicexplorer My bad, try the link again.

Great, I'm happy to keep doing one directory per PR! We found some directories don't even need changes also

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:port-fs branch Jul 12, 2018

@cosmicexplorer

This comment has been minimized.

Copy link
Contributor

cosmicexplorer commented Jul 12, 2018

That link works now! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment