Switch from output_async to spawn_async, and buffer output. #6105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
approved these changes
Jul 13, 2018
| @@ -37,6 +38,25 @@ impl CommandRunner { | |||
| } | |||
| } | |||
|
|
|||
| fn outputs_stream_for_child( | |||
| mut child: Child, | |||
| ) -> Box<Stream<Item = ChildOutput, Error = String> + Send> { | |||
There was a problem hiding this comment.
I know I was the one who said we shouldn't use impl Future, but I'd be tempted to use impl Stream here :P My reasoning being:
- This isn't really a thing we do elsewhere, so it probably doesn't add to confusion
- This won't be passed around to other things which may need to ambiguously handle both
But I definitely don't mind either way
| .map(move |snapshot| FallibleExecuteProcessResult { | ||
| stdout: stdout.freeze(), | ||
| stderr: stderr.freeze(), | ||
| exit_code: exit_code.unwrap_or(-1), |
There was a problem hiding this comment.
I would expect there to always be an exit code, right? Maybe make this an exit_code.ok_or_else(|| "Process had no exit code".to_owned())
There was a problem hiding this comment.
There was a problem hiding this comment.
Aha, in that case can we do -signal rather than -1? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #6089.
Solution
Switch to
spawn_asyncandfoldover a stream of outputs. To stream/duplicate output elsewhere, we'd add logic in thefold.Result
Fixes #6089.