New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Rust to store `unicode` as well as `bytes` #6108

Merged
merged 1 commit into from Jul 13, 2018

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

illicitonion commented Jul 13, 2018

This is currently unused, but will be used to land
#6103 with
DirectoryDigest.fingerprint being a unicode not a bytes.

/cc @Eric-Arellano

Allow Rust to store `unicode` as well as `bytes`
This is currently unused, but will be used to land
#6103 with
DirectoryDigest.fingerprint being a `unicode` not a `bytes`.

@illicitonion illicitonion requested a review from stuhood Jul 13, 2018

@Eric-Arellano

This comment has been minimized.

Copy link
Contributor

Eric-Arellano commented Jul 13, 2018

Thanks Daniel! This patch works from the Python side of things. I changed DirectoryDigest to use unicode instead of bytes, and everything passes 🎉

Once this PR gets merged, I'll push the update to #6103. All the other PRs I have ready to go (about 10) are built on top of #6103, so both this PR and that will be blockers soon until they're merged.

@illicitonion illicitonion merged commit 5da9146 into pantsbuild:master Jul 13, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/storeutf8 branch Jul 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment