New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port buildrefactor to py3 #6109

Merged
merged 3 commits into from Jul 14, 2018

Conversation

Projects
None yet
2 participants
@GoingTharn
Copy link
Contributor

GoingTharn commented Jul 13, 2018

target_roots is going to want a list, not generator

Problem

buildrefactor has one py3 incompatibility

Solution

cast dict.values() call to a list prior to kwarg assignment

cast arg to list
target_roots is going to want a list, not generator
@GoingTharn

This comment has been minimized.

Copy link
Contributor

GoingTharn commented Jul 13, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

@stuhood stuhood merged commit a019b59 into pantsbuild:master Jul 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment