New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PrimitivesSetField in ScalaJs target and minor help text fixup #6113

Merged
merged 2 commits into from Jul 13, 2018

Conversation

Projects
None yet
2 participants
@alanbato
Copy link
Member

alanbato commented Jul 13, 2018

Problem

Fixup the things requested at #6065

Solution

s/SetOfPrimitivesField/PrimitivesSetField

and a change to the wording in the help text of the compiler_option_sets default options.

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

@@ -27,7 +27,8 @@ def register_options(cls, register):

register('--compiler-option-sets', advanced=True, default=[], type=list,
fingerprint=True,
help='The option sets to be enabled for the compilation of this target.')
help='The default for the "compiler_option_sets" argument'

This comment has been minimized.

@stuhood

stuhood Jul 13, 2018

Member

String concatenation won't leave a space here. We generally use a trailing space on the first line.

This comment has been minimized.

@stuhood

stuhood Jul 13, 2018

Member

(I went ahead and used the editing UI to fix this. That's nifty.)

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Jul 13, 2018

I canceled the second run... will merge if the first goes green.

@stuhood stuhood merged commit 9a00b3f into pantsbuild:master Jul 13, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment