New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

futurize confluence #6115

Merged
merged 3 commits into from Jul 21, 2018

Conversation

Projects
None yet
4 participants
@GoingTharn
Copy link
Contributor

GoingTharn commented Jul 13, 2018

Problem

futurize confluence to py3

Solution

Only change from futurize was urllib.error and urllib.request as parse was only used function

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Jul 13, 2018

Sorry, this one will need a rebase to latest master.

from os.path import basename

from future import standard_library
standard_library.install_aliases()

This comment has been minimized.

@Eric-Arellano

Eric-Arellano Jul 13, 2018

Contributor

Hey this won't work as we're expecting, because standard_libary.install_aliases() has to be called before import urllib.parse, which is impossible with the iSort tool.

Instead, please do this

from future.moves.urllib.parse import quote_plus

And then update line 83

use future idiom. fix urllib
urllib py2/py3 difficult.
favor xmlrpc.client in import try as it's 2.7 and 3 compat

@jsirois jsirois merged commit f31e54b into pantsbuild:master Jul 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

futurize confluence (pantsbuild#6115)
use future idiom. fix urllib

favor xmlrpc.client in import try as it's 2.7 and 3 compat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment