New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port cpp to py3 #6116

Merged
merged 4 commits into from Jul 17, 2018

Conversation

Projects
None yet
3 participants
@GoingTharn
Copy link
Contributor

GoingTharn commented Jul 13, 2018

Problem

Porting contrib/cpp to py3

Solution

just added an import

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Jul 13, 2018

Sorry, this will need a rebase to master.

GoingTharn and others added some commits Jul 13, 2018

@Eric-Arellano

This comment has been minimized.

Copy link
Contributor

Eric-Arellano commented Jul 15, 2018

@stuhood it looks like one of the tests timed out.

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Jul 15, 2018

Yep... just restarted that one. But there is also an actual failure.

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Jul 17, 2018

Will merge afterhours.

@stuhood stuhood merged commit baa68af into pantsbuild:master Jul 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment