New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port findbugs to py3 #6120

Merged
merged 2 commits into from Jul 14, 2018

Conversation

Projects
None yet
2 participants
@GoingTharn
Copy link
Contributor

GoingTharn commented Jul 13, 2018

Problem

port to py3

Solution

-- targets = filter(self._is_findbugs_target, self.context.target_roots)
++ targets = [t for t in self.context.target_roots if self._is_findbugs_target(t)]

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Jul 13, 2018

@GoingTharn : I believe you've opened this one twice.

Could you please use the PR titles to indicate which backend/module you're editing?

@GoingTharn

This comment has been minimized.

Copy link
Contributor

GoingTharn commented Jul 13, 2018

Oh of course, I missed that

@GoingTharn GoingTharn changed the title change filter to list comp, add import str Port findbugs to py3 Jul 13, 2018

@stuhood stuhood merged commit f34fd98 into pantsbuild:master Jul 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Jul 14, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment