New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impose a consistent sort on CONTRIBUTORS.md. #6125

Merged
merged 1 commit into from Jul 15, 2018

Conversation

Projects
None yet
3 participants
@jsirois
Copy link
Member

jsirois commented Jul 15, 2018

The sort provided by LC_ALL=C appears to match the sort that ships with
OSX or else every developer except me configures their machine for the C
locale.

Previously I was always getting spurious diffs under my setup:

$ locale
LANG=en_US.UTF-8
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_PAPER="en_US.UTF-8"
LC_NAME="en_US.UTF-8"
LC_ADDRESS="en_US.UTF-8"
LC_TELEPHONE="en_US.UTF-8"
LC_MEASUREMENT="en_US.UTF-8"
LC_IDENTIFICATION="en_US.UTF-8"
LC_ALL=en_US.UTF-8
Impose a consistent sort on CONTRIBUTORS.md.
The sort provided by LC_ALL=C appears to match the sort that ships with
OSX or else every developer except me configures their machine for the C
locale.

Previously I was always getting spurious diffs under my setup:
```
$ locale
LANG=en_US.UTF-8
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_PAPER="en_US.UTF-8"
LC_NAME="en_US.UTF-8"
LC_ADDRESS="en_US.UTF-8"
LC_TELEPHONE="en_US.UTF-8"
LC_MEASUREMENT="en_US.UTF-8"
LC_IDENTIFICATION="en_US.UTF-8"
LC_ALL=en_US.UTF-8
```

@jsirois jsirois requested review from kwlzn and stuhood Jul 15, 2018

@kwlzn

kwlzn approved these changes Jul 15, 2018

@jsirois jsirois merged commit 5d56a59 into pantsbuild:master Jul 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:contributors/consistent-sort branch Jul 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment