New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve output directories if process execution failed #6152

Merged
merged 1 commit into from Jul 17, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented Jul 17, 2018

Right now, this is in an and_then block, so doesn't get called if process execution fails.

Preserve output directories if process execution failed
Right now, this is in an and_then block, so doesn't get called if process execution fails.

@illicitonion illicitonion requested review from stuhood and kwlzn Jul 17, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

preserved_path,
req_description
);
} // Else, workdir gets dropped here

This comment has been minimized.

@stuhood

stuhood Jul 17, 2018

Member

Not critical here, but in future, augmenting this comment with an explicit: mem::drop(workdir) wouldn't hurt.

@stuhood stuhood merged commit 0428780 into pantsbuild:master Jul 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/localexec/preserveonerror branch Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment