New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs_util can list the recursive files in a Directory #6153

Merged
merged 2 commits into from Jul 18, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented Jul 17, 2018

This is useful when debugging that a Directory is not what you expect.

@illicitonion illicitonion requested review from ity and dotordogh Jul 17, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

.and_then(|maybe_dir| match maybe_dir {
Some(dir) => {
for file in dir.get_files() {
files

This comment has been minimized.

@stuhood

stuhood Jul 17, 2018

Member

Could probably acquire the lock around the loop to remove a few acquisitions.

@illicitonion illicitonion merged commit fbb6175 into pantsbuild:master Jul 18, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/fs_util/listfiles branch Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment