New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port java #6159

Merged
merged 2 commits into from Jul 17, 2018

Conversation

Projects
None yet
2 participants
@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Jul 17, 2018

Part of #6062

Eric-Arellano added some commits Jul 17, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

Will merge afterhours.

@stuhood stuhood merged commit e61a164 into pantsbuild:master Jul 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

cosmicexplorer added a commit that referenced this pull request Jul 19, 2018

Fix incorrect use of bytes() when invoking the daemon in a tty (#6181)
### Problem

`pkill -f "pantsd \[" pantsd-runner && ./pants --enable-pantsd help` fails on master when run within a tty because we incorrectly try to pass an `int` directly to a `bytes`. This was introduced during #6159.

### Solution

- Wrap the `bytes()` argument in a list in `NailgunProtocol.isatty_to_env()`.
- Add unit testing which mocks out the tty querying to ensure the environment we return is valid.

### Result

No more crashing when trying to create a pantsd in a tty.

#### Thoughts

This may be another argument for something like #6157. There may also be room for an integration test which opens up a "real" pty to catch issues like these in the future, but it's not clear to me how to do that right now.

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:port-java branch Jul 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment