New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to isort 4.3.4. #6166

Merged
merged 1 commit into from Jul 18, 2018

Conversation

Projects
None yet
3 participants
@jsirois
Copy link
Member

jsirois commented Jul 17, 2018

This picks up python3 std lib module knowledge.

In addition, remove the un-needed isort 3rdparty dep and the
contrib/python/src/python/pants/contrib/python/isort binary. The isort
pex is now directly built via script in pantsbuild/binaries.

Fixes #6149

Upgrade to isort 4.3.4.
This picks up python3 std lib module knowledge.

In addition, remove the un-needed isort 3rdparty dep and the
contrib/python/src/python/pants/contrib/python/isort binary. The isort
pex is now directly built via script in pantsbuild/binaries.

Fixes #6149

@jsirois jsirois requested a review from wisechengyi Jul 17, 2018

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Jul 17, 2018

@jsirois jsirois requested a review from kwlzn Jul 17, 2018

@Eric-Arellano

This comment has been minimized.

Copy link
Contributor

Eric-Arellano commented Jul 17, 2018

Great, thank you John! I'll close the temporary fix PR in favor of this approach.

@stuhood stuhood merged commit 1ad39c1 into pantsbuild:master Jul 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano referenced this pull request Jul 18, 2018

Merged

Fix isort issues #6174

@jsirois jsirois deleted the jsirois:issues/6149 branch Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment