Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Merge subjects and variants into Params, and remove Noop #6170
As described in #5788:
Additionally, as described a while back in #4304, it should be possible to generate concrete subgraphs by removing ambiguity from the
This change merges
This change does not yet expose any sort of UX for providing more than one
referenced this pull request
Jul 17, 2018
2 times, most recently
Jul 25, 2018
This is now reviewable.
It contains a ton of TODOs that I'll either open issues for or resolve, and still has some (trivially, I think) failing tests. But it shouldn't need any fundamental changes.
Where are Aggregations actually used? Can you point at an example (which is tested)?
I'm not convinced all of the tests you're deleting should be deleted... Are some of those to be restored?
I think this could do with a decent prosaic description of what "kinds" of rules we support. Would you be able to put one together (or does one already exist)?
I also have some outstanding comments from my first pass which I think still stand.
left a comment
They were used in (and necessary for)
I plan to heavily extend
All of the deleted tests consumed
If we feel strongly that we should keep them, I think I'd need to dive in on #4005 to allow
That exists in https://github.com/pantsbuild/pants/blob/master/src/python/pants/engine/README.md : I will definitely extend it here to account for
I also fully expect to be able to remove
left a comment
Did a first pass at this. Most of my comments are for small nitpicks.
I like this change quite a bit. I think that, conceptually, param is a much easier thing to explain than subject and variant. And, I think param aligns better with what those things were used for.
This was referenced
Sep 9, 2018
I've rebased this and applied review feedback: only the topmost commit contains anything new.
Having thought a bit more about what rule graph extensibility should look like, I decided to rebase
I'd like to clean up the tests and land this tomorrow if reviewers agree.