New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfmt check more reliably works #6172

Merged
merged 1 commit into from Jul 18, 2018

Conversation

Projects
None yet
2 participants
@illicitonion
Copy link
Contributor

illicitonion commented Jul 18, 2018

We were running --write-mode=diff which used to exit 4 if your code as
incorrectly formatted, and now doesn't. It now only exits non-0 if
your code doesn't parse. --write-mode=check does exit non-zero if
your code isn't correctly formatted, but provides no way of
distinguishing "Your code is incorrectly formatted" from "your code
doesn't parse". So that's nice of it.

rustfmt check more reliably works
We were running `--write-mode=diff` which used to exit 4 if your code as
incorrectly formatted, and now doesn't. It now only exits non-0 if
your code doesn't parse. `--write-mode=check` *does* exit non-zero if
your code isn't correctly formatted, but provides no way of
distinguishing "Your code is incorrectly formatted" from "your code
doesn't parse". So that's nice of it.

@illicitonion illicitonion requested review from stuhood and jsirois Jul 18, 2018

@illicitonion illicitonion merged commit b902e7f into pantsbuild:master Jul 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/rustfmt branch Jul 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment