New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to specify chunk size #6173

Merged
merged 2 commits into from Jul 19, 2018

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

illicitonion commented Jul 18, 2018

Also, default is 3M not 10M, as grpc has a ~4M limit per-message

Allow user to specify chunk size
Also, default is 3M not 10M, as grpc has a ~4M limit per-message

@illicitonion illicitonion requested review from dgassaway and dotordogh Jul 18, 2018

.takes_value(true)
.long("chunk-bytes")
.required(false)
.default_value(&format!("3 * 1024 * 1024"))

This comment has been minimized.

@stuhood

stuhood Jul 18, 2018

Member

This... confuses me a bit. Is clap going to parse this string and then evaluate it to get the default value?

Maybe it's correct, just pointing it out as odd.

This comment has been minimized.

@illicitonion

illicitonion Jul 18, 2018

Contributor

Oops. Fixed!

@illicitonion illicitonion merged commit c81d4c1 into pantsbuild:master Jul 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/fs_util/chunksize branch Jul 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment