New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print stack trace on ExecutionGraph task failures #6177

Merged
merged 2 commits into from Jul 23, 2018

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

illicitonion commented Jul 18, 2018

Fixes #6150

@illicitonion illicitonion requested a review from baroquebobcat Jul 18, 2018

@baroquebobcat
Copy link
Contributor

baroquebobcat left a comment

Looks good to me. I'd like a test for it in https://github.com/pantsbuild/pants/blob/master/tests/python/pants_test/tasks/test_execution_graph.py

I think you could set one up by passing a different logger than the default one that those tests use (https://github.com/pantsbuild/pants/blob/master/tests/python/pants_test/tasks/test_execution_graph.py#L21)

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

@illicitonion illicitonion force-pushed the twitter:dwagnerhall/stacktrace branch from 74e597c to b94ff37 Jul 23, 2018

@stuhood
Copy link
Member

stuhood left a comment

Thanks again.

@stuhood stuhood merged commit 925d184 into pantsbuild:master Jul 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/stacktrace branch Jul 24, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment