New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert `fmt.isort` to bootstrapping isort. #6182

Merged
merged 3 commits into from Jul 19, 2018

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

jsirois commented Jul 19, 2018

Previously we relied on a pre-deployed isort.pex binary; now we
create an isort.pex locally as-needed.

Convert `fmt.isort` to bootstrapping isort.
Previously we relied on a pre-deployed `isort.pex` binary; now we
create an `isort.pex` locally as-needed.
@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Jul 19, 2018

NB: Needs tests for the new IsortPrep task which is only tested indirectly via the IsortRun unit and integration tests right now.

@stuhood
Copy link
Member

stuhood left a comment

Thanks!

address=address,
target_type=PythonRequirementLibrary,
requirements=[PythonRequirement(r)
for r in 'isort=={}'.format(self.get_options().version), 'setuptools']

This comment has been minimized.

@stuhood

stuhood Jul 19, 2018

Member

Should this be using a pinned version of setuptools? Also, should the singular version option be replaced with a list of requirements strings so that someone could change both isort and setuptools if need be?

This comment has been minimized.

@jsirois

jsirois Jul 19, 2018

Member

Nope - isort just simply does not require it anywhere. It only relies on it in main.py for a feature we do not use:
https://github.com/timothycrosley/isort/blob/ea10824e12e7d9409e7a8918094c1dbfa2d66f05/isort/main.py#L47-L50

This comment has been minimized.

@jsirois

jsirois Jul 19, 2018

Member

I left version as-is although I moved it into an 'isort' scoped subsystem so the option name stays the same. I did add an --additional-requirements option though to house the current need for setuptools so that is editable.

@jsirois jsirois merged commit a51b977 into pantsbuild:master Jul 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:isort/bootstrap_instead_of_binary branch Jul 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment