New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci deduplication #6186

Merged
merged 3 commits into from Jul 19, 2018

Conversation

Projects
None yet
3 participants
@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Jul 19, 2018

  • Removes duplication of test setup
  • Adds top level comment to each test

See https://blog.daemonl.com/2016/02/yaml.html for the syntax and use of anchors and references in YAML.

tl;dr

foo: &my_ref_name   # these names don't have to correspond
  k1: v1
  k2: v2

my_usage: 
  <<: *my_ref_name  # extends 
  k1: override_val  # you can override!

Connected to conversation in #6183

.travis.yml Outdated
- sudo rm -rf /usr/lib/jvm/java-1.6.0-openjdk-amd64
- sudo rm -rf /usr/lib/jvm/java-6-openjdk-amd64
- jdk_switcher use oraclejdk8
# Integration tests - shard 4

This comment has been minimized.

@jsirois

jsirois Jul 19, 2018

Member

The comments don't seem to help much at all on these abbreviated shards since env is very nearby. On the handful of remaining shards its maybe marginally hard? Seems redundant to me anyway.

@stuhood
Copy link
Member

stuhood left a comment

This looks great! Thanks.

@jsirois jsirois merged commit 6dec8de into pantsbuild:master Jul 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:ci-duplication branch Jul 22, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Ci deduplication (pantsbuild#6186)
Deduplicate test config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment