New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[missing-deps-suggest] move buildozer cli to a new line #6190

Merged
merged 2 commits into from Jul 23, 2018

Conversation

Projects
None yet
3 participants
@baroquebobcat
Copy link
Contributor

baroquebobcat commented Jul 19, 2018

Currently, the buildozer command is on the same line as the rest of the message. This makes it harder to select, particularly when the command is long.

Putting the buildozer command on a new line will make it easier to copy / paste.

[missing-deps-suggest] move buildozer cli to a new line
Putting the buildozer command on a new line will make it easier to copy / paste

@baroquebobcat baroquebobcat requested a review from illicitonion Jul 19, 2018

@illicitonion
Copy link
Contributor

illicitonion left a comment

Very handy, thanks!

@@ -33,7 +33,7 @@ def test_missing_deps_found_buildozer(self):
'--compile-zinc-buildozer=path/to/buildozer',
])
self.assert_failure(run)
self.assertTrue(re.search("path/to/buildozer 'add dependencies 3rdparty:guava' " + target,
self.assertTrue(re.search("\n +path/to/buildozer 'add dependencies 3rdparty:guava' " + target,

This comment has been minimized.

@illicitonion

illicitonion Jul 20, 2018

Contributor

Mirco-nit: s/+/*/?

@baroquebobcat baroquebobcat merged commit 9fb59ee into pantsbuild:master Jul 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

[missing-deps-suggest] move buildozer cli to a new line (pantsbuild#6190
)

Currently, the buildozer command is on the same line as the rest of the message. This makes it harder to select, particularly when the command is long.

Putting the buildozer command on a new line will make it easier to copy / paste.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment