New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port releases #6194

Merged
merged 2 commits into from Jul 21, 2018

Conversation

Projects
None yet
3 participants
@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Jul 19, 2018

Part of #6062

@Eric-Arellano

This comment has been minimized.

Copy link
Contributor

Eric-Arellano commented Jul 19, 2018

Warning there are no tests for releases/packages.py. Is there any way for us to test this behavior?

@jsirois

This comment has been minimized.

Copy link
Member

jsirois commented Jul 19, 2018

Sure, run these 3:

./pants run src/python/pants/releases:packages -- list
./pants run src/python/pants/releases:packages -- list-owners
./pants run src/python/pants/releases:packages -- check-my-ownership

For the last you may be prompted by a backtrace to:

$ cat << EOF > ~/.pypirc
> [server-login]
> username: bob
> EOF
@Eric-Arellano

This comment has been minimized.

Copy link
Contributor

Eric-Arellano commented Jul 19, 2018

Perfect, that caught a bug. Thanks John!

@stuhood stuhood merged commit b199eff into pantsbuild:master Jul 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:port-releases branch Jul 22, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment