New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port task #6200

Merged
merged 3 commits into from Jul 22, 2018

Conversation

Projects
None yet
3 participants
@Eric-Arellano
Copy link
Contributor

Eric-Arellano commented Jul 19, 2018

Part of #6062

Eric-Arellano added some commits Jul 19, 2018

@stuhood

This comment has been minimized.

Copy link
Member

stuhood commented Jul 21, 2018

This one has some failures in CI.

@@ -231,7 +232,7 @@ def get_targets(self, predicate=None):
:API: public
"""
return (self.context.targets(predicate) if self.act_transitively
else filter(predicate, self.context.target_roots))
else [root for root in self.context.target_roots if predicate(root)])

This comment has been minimized.

@jsirois

jsirois Jul 22, 2018

Member

The predicate can be None and then this goes boom now.

@jsirois jsirois merged commit 327ddc5 into pantsbuild:master Jul 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Eric-Arellano Eric-Arellano deleted the Eric-Arellano:port-task branch Jul 22, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment