New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused custom `working_set` parameters. #6221

Merged
merged 1 commit into from Jul 23, 2018

Conversation

Projects
None yet
2 participants
@jsirois
Copy link
Member

jsirois commented Jul 23, 2018

If BuildConfigInitializer.get were to be called with a working_set
different from that passed on the initial call, a caching bug would be
triggered. Eliminate this un-exercised possibility.

Remove unused custom `working_set` parameters.
If `BuildConfigInitializer.get` were to be called with a non-`None`
`working_set` different from an initial call, a caching bug would be
triggered. Eliminate this un-exercised possibility.
@stuhood
Copy link
Member

stuhood left a comment

Thanks.

@jsirois jsirois merged commit d748a10 into pantsbuild:master Jul 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:BuildConfigInitializer/fix_unexercised_caching_bug branch Jul 23, 2018

CMLivingston pushed a commit to CMLivingston/pants that referenced this pull request Aug 27, 2018

Remove unused custom `working_set` parameters. (pantsbuild#6221)
If `BuildConfigInitializer.get` were to be called with a `working_set`
different from that passed on the initial call, a caching bug would be
triggered. Eliminate this un-exercised possibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment